Skip to content

fix: NetworkEndPoint simplify to NetworkEndpoint in 2021.3 editor #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .yamato/_triggers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ develop_nightly:
dependencies:
# Run project standards to verify package/default project
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
# - .yamato/project-standards.yml#standards_ubuntu_testproject_2021.3 # Tracked in MTT-11382
- .yamato/project-standards.yml#standards_ubuntu_testproject_2021.3
# Run APV jobs to make sure the change won't break any dependants
- .yamato/wrench/preview-a-p-v.yml#all_preview_apv_jobs
# Run package EditMode and Playmode tests on desktop platforms on trunk and 2021.3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1241,16 +1241,16 @@ public NetworkEndpoint GetEndpoint(ulong clientId)
}
#else
/// <summary>
/// Provides the <see cref="NetworkEndPoint"/> for the NGO client identifier specified.
/// Provides the <see cref="NetworkEndpoint"/> for the NGO client identifier specified.
/// </summary>
/// <remarks>
/// - This is only really useful for direct connections.
/// - Relay connections and clients connected using a distributed authority network topology will not provide the client's actual endpoint information.
/// - For LAN topologies this should work as long as it is a direct connection and not a relay connection.
/// </remarks>
/// <param name="clientId">NGO client identifier to get endpoint information about.</param>
/// <returns><see cref="NetworkEndPoint"/></returns>
public NetworkEndPoint GetEndpoint(ulong clientId)
/// <returns><see cref="NetworkEndpoint"/></returns>
public NetworkEndpoint GetEndpoint(ulong clientId)
{
if (m_Driver.IsCreated && NetworkManager != null && NetworkManager.IsListening)
{
Expand All @@ -1261,7 +1261,7 @@ public NetworkEndPoint GetEndpoint(ulong clientId)
return m_Driver.RemoteEndPoint(networkConnection);
}
}
return new NetworkEndPoint();
return new NetworkEndpoint();
}
#endif

Expand Down