Skip to content

fix: Sync transform position on spawn #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Mar 25, 2025

MTTB-90
MTTB-1131

Changelog

  • Fixed: Correctly sync network transform using world space on spawn

Testing and Documentation

  • No tests have been added.

@EmandM EmandM requested a review from a team as a code owner March 25, 2025 15:48
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 26, 2025 15:36
@NoelStephensUnity NoelStephensUnity merged commit 02128fa into develop Mar 26, 2025
40 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/mttb-90-apply-world-position-on-transform-sync branch March 26, 2025 18:42
EmandM added a commit that referenced this pull request Mar 31, 2025
1. Adds a test replicating the bug fixed in #3361 
2. Move the code to sync prefabs for late joining clients into the base
`NetcodeIntegrationTest`
3. Fix some pvp exceptions

## Changelog

- Added: Test covering the bug fixed in #3361

## Testing and Documentation

- Adds Unit test

---------

Co-authored-by: Noel Stephens <[email protected]>
EmandM added a commit that referenced this pull request Mar 31, 2025
Adds a test replicating the bug fixed in #3361 

Move the code to sync prefabs for late joining clients into the
`NetcodeIntegrationTest`

## Changelog

- Added: Test for #3361 

## Testing and Documentation

- Adds Unit test

<!-- Uncomment and mark items off with a * if this PR deprecates any
API:
### Deprecated API
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter
yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they
should use instead.
-->

---------

Co-authored-by: Noel Stephens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants