refactor: Minor cleanups in Unity Transport #3377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few minor cleanups in Unity Transport:
NetworkDriver
accessor. There's a publicGetNetworkDriver
nowadays that can be used for the same purpose.using
directive for transport errors which avoids using the full (and long) type name.m_ServerClientId
. Plus, theListening
state did not have the same meaning as it does in NGO itself, which could lead to confusion.ErrorUtilities
to avoid the useless constants and only providing strings for errors users can actually do something about. Also moved it to the bottom of the file. The top is too prime real estate for such a minor utility. :PChangelog
N/A
Testing and Documentation