Skip to content

fix: Don't accept invalid connections in UnityTransport.Send [1.X] #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

fix: Don't accept invalid connections in UnityTransport.Send [1.X] #3383

merged 5 commits into from
Apr 9, 2025

Conversation

simon-lemay-unity
Copy link
Contributor

Backport of PR #3382.

Changelog

  • Fixed: Fixed an issue in UnityTransport where the transport would accept sends on invalid connections, leading to a useless memory allocation and confusing error message.

Testing and Documentation

  • Includes integration test.
  • No documentation changes or additions were necessary.

@simon-lemay-unity simon-lemay-unity requested a review from a team as a code owner April 7, 2025 15:17
@simon-lemay-unity simon-lemay-unity merged commit 9738a6e into develop Apr 9, 2025
39 checks passed
@simon-lemay-unity simon-lemay-unity deleted the fix-1.x/unity-transport-invalid-connections branch April 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalChrobot michalChrobot michalChrobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-lemay-unity @michalChrobot