fix: In-Scene Placed Object Parenting, Serialization Order, and Transform Parent Detection #3387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
added
the
port:1.x-completed
NoelStephensUnity
deleted the
fix/in-scene-placed-network-object-parenting
branch
NoelStephensUnity
added a commit
that referenced
this pull request
Apr 10, 2025
…ort) (#3388) This is the back port of #3387 that resolves some issues with in-scene placed NetworkObjects in parent-child hierarchy and the synchronization of late joining clients when the hierarchy has changed from that of its default hierarchy defined within the scene. [MTT-11883](https://jira.unity3d.com/browse/MTT-11883) ## Changelog - Fixed: Issue where in-scene placed `NetworkObjects` could fail to synchronize its transform properly (especially without a `NetworkTransform`) if their parenting changes from the default when the scene is loaded and if the same scene remains loaded between network sessions while the parenting is completely different from the original hierarchy. - Changed: The scene loading event serialization order for in-scene placed `NetworkObject`s to be based on their parent-child hierarchy. ## Testing and Documentation - Includes no additional tests (_requires manual testing due to scene loading constraints_). - No documentation changes or additions were necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues with in-scene placed NetworkObject parenting where the original parent has changed. This resolves the issue where loading a scene would not order the serialization of loaded in-scene placed NetworkObjects based on their parent-child hierarchy.
This also resolves an issue where a
NetworkTransformwould think it was parented if nested under anything as well as removes the spamming error message when parenting aNetworkObjectwithNetworkTransformand using local space for synchronization (can be handled in documentation as to why this is a bad idea but there may be edge cases where a user might want to do this anyway).MTT-11883
Changelog
NetworkObjectscould fail to synchronize its transform properly (especially without aNetworkTransform) if their parenting changes from the default when the scene is loaded and if the same scene remains loaded between network sessions while the parenting is completely different from the original hierarchy.NetworkObjects to be based on their parent-child hierarchy.NetworkObjectwithNetworkTransformis parented and placed in local space when using rigidbody for motion.Testing and Documentation