ci: Adding minimal supported editor specific tests and improving trigger jobs coverage #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y IF those will pass, it will run the rest of PR trigger dependencies
… of project pack job
michalChrobot
requested review from
NoelStephensUnity,
EmandM and
a team
as code owners
|
|
michalChrobot
added a commit
that referenced
this pull request
Apr 16, 2025
This PR aims to fix an oversight of having invalid dependency in Nightly trigger as well as adding more variations to PR trigger job. Additionally it introduces _**run_quick_checks**_ job that was added as a requirement for package_pack and project_pack jobs. It will run as a first check (also on PR trigger) to catch any basic errors (PVP and project standards) and ONLY IF this job will pass, the rest of PR trigger job dependencies will be executed. This way provides faster feedback loop for developers and allow to minimize resource usage when unnecessary Failing result may look like this  Where we can see that many jobs failed but in reality we can see that only PVP jobs failed and others were never executed and failed due to their dependencies ## Backport This is specific change to develop branch but it's somewhat reflected in #3409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add minimal supported editor (6000.0) specific tests so we can differentiate between those and trunk tests as well as adding more variations to PR trigger job.
Additionally it introduces run_quick_checks job that was added as a requirement for package_pack and project_pack jobs. It will run as a first check (also on PR trigger) to catch any basic errors (PVP and project standards) and ONLY IF this job will pass, the rest of PR trigger job dependencies will be executed.
This way provides faster feedback loop for developers and allow to minimize resource usage when unnecessary
Failing result may look like this
Where we can see that many jobs failed but in reality we can see that only PVP jobs failed and others were never executed and failed due to their dependencies
Backport
This is specific change to develop-2.0.0 branch but it's somewhat reflected in #3408