Skip to content

chore: [Backport] Add test for unregistering custom message handlers #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -279,5 +279,38 @@ public unsafe void ErrorMessageIsPrintedWhenAttemptingToSendNamedMessageWithTooB
Assert.IsTrue(message.Contains($"Given message size ({msgSize} bytes) is greater than the maximum"), $"Unexpected exception: {message}");
}
}

[Test]
public void NamedMessageHandlerIsUnregisteredWithoutException()
{
var messageName = Guid.NewGuid().ToString();
const int numMessagesToSend = 3;
const int expectedMessageHandlerCallCount = 1;

var messageHandlerCalled = 0;
m_ServerNetworkManager.CustomMessagingManager.RegisterNamedMessageHandler(
messageName,
(_, _) =>
{
messageHandlerCalled++;
m_ServerNetworkManager.CustomMessagingManager.UnregisterNamedMessageHandler(messageName);
});

var messageContent = new ForceNetworkSerializeByMemcpy<Guid>(Guid.NewGuid());
var writer = new FastBufferWriter(1300, Allocator.Temp);
using (writer)
{
writer.WriteValueSafe(messageContent);
for (var i = 0; i < numMessagesToSend; i++)
{
m_ServerNetworkManager.CustomMessagingManager.SendNamedMessage(
messageName,
m_ServerNetworkManager.LocalClientId,
writer);
}
}

Assert.AreEqual(expectedMessageHandlerCallCount, messageHandlerCalled);
}
}
}
1 change: 1 addition & 0 deletions pvpExceptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,7 @@
"Unity.Netcode.RuntimeTests.NamedMessageTests: IEnumerator WhenSendingNamedMessageToAll_AllClientsReceiveIt(): undocumented",
"Unity.Netcode.RuntimeTests.NamedMessageTests: void WhenSendingNamedMessageToNullClientList_ArgumentNullExceptionIsThrown(): undocumented",
"Unity.Netcode.RuntimeTests.NamedMessageTests: void ErrorMessageIsPrintedWhenAttemptingToSendNamedMessageWithTooBigBuffer(): undocumented",
"Unity.Netcode.RuntimeTests.NamedMessageTests: void NamedMessageHandlerIsUnregisteredWithoutException(): undocumented",
"Unity.Netcode.RuntimeTests.UnnamedMessageTests: undocumented",
"Unity.Netcode.RuntimeTests.UnnamedMessageTests: NumberOfClients: undocumented",
"Unity.Netcode.RuntimeTests.UnnamedMessageTests: IEnumerator UnnamedMessageIsReceivedOnClientWithContent(): undocumented",
Expand Down