fix: Reset NetworkClient upon shutdown #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
added
the
port:1.x-needed
NoelStephensUnity
added a commit
that referenced
this pull request
Jun 9, 2025
NoelStephensUnity
added
port:1.x-completed
EmandM
reviewed
Jun 10, 2025
com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Show resolved
Hide resolved
EmandM
approved these changes
Jun 10, 2025
NoelStephensUnity
added a commit
that referenced
this pull request
Jun 10, 2025
This PR addresses some NetworkManager instance clean up when shutdown including the ConnectionManager's NetworkClient. This PR also includes a clean up for NetworkObject upon despawning in the event one is using an object pool. [MTT-12384](https://jira.unity3d.com/browse/MTT-12384) ## Changelog - Fixed: Issue where `NetworkClient` could persist some settings if re-using the same `NetworkManager` instance. - Fixed: Issue where a pooled `NetworkObject` was not resetting the internal latest parent property when despawned. ## Testing and Documentation - Includes integration test updates. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport This is a back port of #3491. <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. -->
NoelStephensUnity
deleted the
fix/reset-networkclient-completely-upon-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some NetworkManager instance clean up when shutdown including the ConnectionManager's NetworkClient.
This PR also includes a clean up for NetworkObject upon despawning in the event one is using an object pool.
MTT-12384
Changelog
NetworkClientcould persist some settings if re-using the sameNetworkManagerinstance.NetworkObjectwas not resetting the internal latest parent property when despawned.Testing and Documentation
Backport
This requires a back port for pertinent/similar areas. (#3494)