Make the demoRecorder write the experience on reset #3463
Conversation
|
BTW can you re-record |
| { | ||
| AgentAction(m_Action.vectorActions); | ||
| } | ||
| AgentAction(m_Action.vectorActions); | ||
| } | ||
| } | ||
|
|
||
| void DecideAction() | ||
| { | ||
| m_Action.vectorActions = m_Brain?.DecideAction(); |
There was a problem hiding this comment.
Can we just call ResetData() here if there aren't any vectorActions?
There was a problem hiding this comment.
Yeah, I think that might be better; ResetData() resets the stored actions, but this change keeps them (possibly with stale data).
There was a problem hiding this comment.
We are not really reseting the data, we are generating a vector of zeros in the case the action is null
There was a problem hiding this comment.
Alright, changed it since there seems to be consensus.
There was a problem hiding this comment.
Then how about moving the vectorAction code from ResetData to a new method (ResetActions()?), call that from ResetData, and call it here?
There was a problem hiding this comment.
Sorry, missed your most recent comment before I made mine.
* Make the demoRecorder write the experience on reset * do nothing if demostore is null * Calling reset data if the action is null
Proposed change(s)
Fixing the demo recording of experiences when the agent is done
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
ML-640
Types of change(s)
Checklist
Other comments