Skip to content

[MLA-803] Add timer metadata to C# and python #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Apr 8, 2020

Proposed change(s)

The main goal of this was to add a version string to the timer data, but might as well add some useful metadata while I'm at it.

C#:

    "metadata": {
        "timer_format_version": "0.1.0",
        "start_time_seconds": "1586382781",
        "unity_version": "2018.4.17f1",
        "communication_protocol_version": "0.15.0",
        "package_version": "0.15.0-preview",
        "scene_name": "Basic",
        "end_time_seconds": "1586382784"
    }

python:

    "metadata": {
        "timer_format_version": "0.1.0",
        "start_time_seconds": "1586382867",
        "python_version": "3.7.6 (default, Dec 30 2019, 19:38:28) \n[Clang 11.0.0 (clang-1100.0.33.16)]",
        "mlagents_version": "0.16.0.dev0",
        "mlagents_envs_version": "0.16.0.dev0",
        "communication_protocol_version": "0.15.0",
        "tensorflow_version": "2.0.1",
        "end_time_seconds": "1586382879"
    }

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

/// <summary>
/// Gauge Nodes to measure arbitrary values.
/// </summary>
[DataMember(Name = "gauges", EmitDefaultValue = false)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since only the root node needs gauges and metadata, I made the RootNode a separate class. Just a memory micro-optimization.

@chriselion chriselion requested a review from xiaomaogy April 8, 2020 22:27
@chriselion chriselion merged commit ef51197 into master Apr 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the MLA-803-timer-metadata branch April 8, 2020 22:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants