-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[refactor] Move configuration files to single YAML file #3791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@anupambhatnagar - this will definitely break daily CI - what steps should I take to adapt the ml-agents-cloud utility to match? |
… develop-single-config
… develop-single-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you generate all of these files. I worry now about keeping track of changing defaults. I know that moving the defaults into code is out of the scope, but I just want to make sure we aren't signing up for the extra work that might be associated with managing multiple dozen config files now.
I also remember us talking about separating the YAML behavior section into a trainer and model sub-sections. Is that out of scope as well, or has the plan changed? I think it would definitely improve interpretability.
@awjuliani I still want to split the YAML to trainer and model. With luck that will be done after the other CLI and output file changes are done. The files were generated using a script that loaded the old config's default and overrode them using the config, then outputted the new YAML. I'm also worried about the files diverging before we are able to create the default values in code. This PR is technically still compatible with the old config files (as long as you add Would it be a good idea to have an intermediary step that uses the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I recommend running it on one scene with ml-agents-cloud to test the new workflow.
Proposed change(s)
This PR refactors the YAML configuration files into a per-environment format. Each YAML now contains both the behavior configurations/hyperparameters, as well as curriculum and parameter variation configurations. The example YAMLs were reformatted to reflect this.
To be done in this PR:
Documentation changesNot done in this PR:
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://docs.google.com/document/d/1uyk5JVNevfWy2DmqVHy19lcDzyQCNppPxkPOgJcQ7z4/edit#heading=h.sozm3sblhtke
Types of change(s)
Checklist
Other comments