Renaming max_step to interrupted in TermialStep(s)

[vincentpierre]

Proposed change(s)

Renaming max_step to interrupted in TermialStep(s)
interrupted is more general and more descriptive of what that flag actually represents.
Disambiguates trainer max_steps from agent max_steps on Python

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

• Bug fix
• New feature
• Code refactor
• Breaking change
• Documentation update
• Other : renaming

Checklist

• Added tests that prove my fix is effective or that my feature works
• Updated the changelog (if applicable)
• Updated the documentation (if applicable)
• Updated the migration guide (if applicable)

Other comments

[ervteng]

Did we ever decide to propagate the enum (done or interrupted for TerminalSteps) into the Python side?

Now I remember that we decided this was too cumbersome, e.g. TerminalStep.state == StateType.done. Having two flags seems fine.

[ervteng]

👍

[vincentpierre]

Now I remember that we decided this was too cumbersome, e.g. TerminalStep.state == StateType.done. Having two flags seems fine.

We no longer need two flags since the done flag is now implicit if the Agent is in the TerminationSteps

I will wait on release to be merged into master to merge this.