Skip to content

Add Dynamic Walker. Improved Ragdoll Stability/Performance #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 133 commits into from
Jun 4, 2020

Conversation

Hunter-Unity
Copy link
Contributor

Proposed change(s)

Removed the Walker environment and added WalkerDynamic and WalkerStatic environments. The ragdoll has been rebuilt to improve stability & performance.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • [ x] Bug fix
  • [ x] New feature
  • [ x] Code refactor
  • Breaking change
  • [ x] Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • [ x] Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@@ -1,8 +1,8 @@
fileFormatVersion: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should have a demo here

Comment on lines +14 to +17
[Header("Orientation")] [Space(10)]
//This will be used as a stable reference point for observations
//Because ragdolls can move erratically, using a standalone reference point can significantly improve learning
public GameObject orientationCube;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this after the body part section.

@vincentpierre
Copy link
Contributor

Don't forget to remove the extra demo file !

@Hunter-Unity Hunter-Unity merged commit ccca2fb into master Jun 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the hh/develop/dynamic-walker branch June 4, 2020 17:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants