Skip to content

[bug-fix] Fix issue with SAC updating too much on resume #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented May 29, 2020

Proposed change(s)

SAC when resuming from a checkpoint would do many updates before continuing to step the environment. This is because we don't set the update_steps properly when resuming from a checkpoint, so the SAC trainer will update until it has enough update_steps.

Also fixes a bug where SAC doesn't update even after hitting buffer_init_steps.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

@ervteng ervteng requested a review from andrewcoh May 29, 2020 02:12
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ervteng ervteng merged commit c359490 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-fixsacstepsperupdate branch June 1, 2020 21:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants