-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Actuator Module self contained without other changes. #4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see the BufferedDiscreteActionMask
mentioned in the PR comment, is it still in the PR?
I made some initial comments but I need to review it some more.
com.unity.ml-agents/Runtime/Actuators/ActuatorDiscreteActionMask.cs
Outdated
Show resolved
Hide resolved
…ay for continuous actions spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final nits, but looks good!
Co-authored-by: Chris Elion <[email protected]>
Co-authored-by: Chris Elion <[email protected]>
Proposed change(s)
Add the Actuator abstraction to ML-Agents as a self-contained module in order to avoid having an enormous pull request.
Notable Additions:
Questionable names:
TODO:
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-789
Types of change(s)
Checklist
Other comments