Skip to content

[MLA-1233] Remove stats.CSVWriter #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2020
Merged

[MLA-1233] Remove stats.CSVWriter #4300

merged 4 commits into from
Aug 4, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Aug 4, 2020

Proposed change(s)

CSV stats have been deprecated for several months. This removes them.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-1233

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested a review from ervteng August 4, 2020 03:34
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note in Background-TensorFlow.md that CSVs can be downloaded from the TB interface?

@@ -235,6 +235,7 @@ def advance(self) -> None:
with hierarchical_timer("_update_policy"):
if self._update_policy():
for q in self.policy_queues:
time.sleep(10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't mean to check that in. Reverting it.

@chriselion chriselion merged commit 2d0eb61 into master Aug 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the MLA-1233-remove-csv branch August 4, 2020 23:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants