Skip to content

add build-in module dependencies #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Conversation

chriselion
Copy link
Contributor

Proposed change(s)

Add dependencies on built-in modules.

  • physics packages for raycasting
  • imageconversion for PNG compression on visual observations
  • jsonserialize for timers

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-1273
https://unity.slack.com/archives/C26EP4SUQ/p1597860403107900
https://docs.unity3d.com/2020.2/Documentation/Manual/pack-build.html

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested a review from surfnerd August 19, 2020 20:36
@chriselion
Copy link
Contributor Author

Note that we also need to add XR as a dependency from com.unity.ml-agents.extensions (for the Pose class), but that can be a different PR (so that this can be 🍒 ⛏️ ed to the verified branch).

@chriselion chriselion merged commit 7d9ce4e into master Aug 19, 2020
@chriselion chriselion deleted the MLA-1273-add-modules-as-deps branch September 16, 2020 17:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants