Skip to content

[feature] Add small CNN for grids 5x5 and up #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2020
Merged

[feature] Add small CNN for grids 5x5 and up #4434

merged 5 commits into from
Sep 2, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Aug 28, 2020 •
edited
Loading

Proposed change(s)

Adds a MATCH3 CNN that can be used for grids down to 5x5.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Network architecture used by King in this paper: https://www.researchgate.net/publication/328307928_Human-Like_Playtesting_with_Deep_Learning

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion reviewed Aug 28, 2020
View reviewed changes
ml-agents/mlagents/trainers/settings.py Outdated
@@ -59,6 +59,7 @@ def as_dict(self):


class EncoderType(Enum):
SMALL = "small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call it "match3"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to MATCH3 = "match3"

chriselion
chriselion approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, any reason not to merge, or you want me to try it on my example first?

@ervteng
Copy link
Contributor Author

ervteng commented Aug 28, 2020

Looks good, any reason not to merge, or you want me to try it on my example first?

Need to add tests for it, but from what I can tell it trains fine and can be merged.

@ervteng ervteng changed the title [DO NOT MERGE] Add small CNN for grids 5x5 and up [feature] Add small CNN for grids 5x5 and up Aug 29, 2020
@ervteng ervteng marked this pull request as ready for review August 29, 2020 00:15
@ervteng
Copy link
Contributor Author

ervteng commented Aug 29, 2020

Updated the PR - should be ready for production now

@ervteng ervteng merged commit a14730f into master Sep 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-small-cnn branch September 2, 2020 00:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @chriselion