add to_string for samplers #4484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcoh
commented
Sep 14, 2020
| @@ -144,11 +145,16 @@ def update_lessons( | |||
| self._smoothed_values[param_name] = new_smoothing | |||
| if must_increment: | |||
| GlobalTrainingStatus.set_parameter_state( | |||
| param_name, StatusType.LESSON_NUM, lesson_num + 1 | |||
There was a problem hiding this comment.
lesson_num + 1 occurred in 2-3 places
vincentpierre
approved these changes
Sep 14, 2020
chriselion
reviewed
Sep 15, 2020
chriselion
reviewed
Sep 15, 2020
| """ | ||
| Helper method to output sampler stats to console. | ||
| """ | ||
| return f"Float: value={self.value}" |
There was a problem hiding this comment.
Another approach would be to use __repr__, and make the string sufficient to reconstruct the object:
So in this case it would be something like return f"ConstantSettings(value={self.value})"
Co-authored-by: Chris Elion <[email protected]>
chriselion
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
This increases the verbosity of the curriculum lesson changes by adding to_strings to the sampler classes. The lesson updates would now output the sampler stats in addition to the lesson and parameter name to the console. See below for sample.
This was done to address a request here #4464
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments