Skip to content

Add Visual3DBall scene #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Oct 7, 2020
Merged

Add Visual3DBall scene #4513

merged 47 commits into from
Oct 7, 2020

Conversation

dongruoping
Copy link
Contributor

@dongruoping dongruoping commented Sep 25, 2020

Proposed change(s)

Add a visual version of 3DBall. The agent takes 84x84 camera frame with frame stacking of 4 as input.
A Use Vec Obs option is added to 3DBall agent.

This can be served as a good example to demonstrate the use of visual frame-stacking for the newly added stacking feature for visual/compressed observation

This PR will wait until #4476 is merged.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion
Copy link
Contributor

Not sure if it matters, but if you look at the Camera preview, you can see the neighboring agents:
image

Can you check in a model file (maybe once you finish with the other PR and enable stacking)?

@dongruoping
Copy link
Contributor Author

Oops I've fixed it when running experiment but somehow didn't include it. It should be fixed now.
And sure I'll add a model file.

Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he colors of the agents should not be green. Green is reward in our informal color coding, blue and purple are agent color.
Also, make sure you give a model of the agent.

@dongruoping
Copy link
Contributor Author

I think he colors of the agents should not be green. Green is reward in our informal color coding, blue and purple are agent color.
Also, make sure you give a model of the agent.

Should I use either blue or purple? I did that just to make a difference between the original 3DBall and the Visual one.

@vincentpierre
Copy link
Contributor

Ok I'll run more times to get a better number. This worked when I tried last time.

Does the scene use stacking by default or do I need to change something?

@dongruoping
Copy link
Contributor Author

Ok I'll run more times to get a better number. This worked when I tried last time.

Does the scene use stacking by default or do I need to change something?

Oh so this one is still waiting for the stacking PR to merge (thus I made this one as draft) and will add default stacking after that.
Sorry I didn't made it clear.

@dongruoping dongruoping marked this pull request as ready for review October 6, 2020 23:31
@@ -9,6 +9,7 @@ public class Ball3DAgent : Agent
{
[Header("Specific to Ball3D")]
public GameObject ball;
public bool useVecObs;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a Tooltip to explain that this needs to be checked in the 3DBall scene but unchecked in the Visual3DBall scene (since it is a public inspector).

@dongruoping dongruoping merged commit 53c27ee into master Oct 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-vis-3dball branch October 7, 2020 18:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants