-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add Visual3DBall scene #4513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Visual3DBall scene #4513
Conversation
Oops I've fixed it when running experiment but somehow didn't include it. It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think he colors of the agents should not be green. Green is reward in our informal color coding, blue and purple are agent color.
Also, make sure you give a model of the agent.
Should I use either blue or purple? I did that just to make a difference between the original 3DBall and the Visual one. |
Does the scene use stacking by default or do I need to change something? |
Oh so this one is still waiting for the stacking PR to merge (thus I made this one as draft) and will add default stacking after that. |
Co-authored-by: Chris Elion <[email protected]>
Co-authored-by: Chris Elion <[email protected]>
@@ -9,6 +9,7 @@ public class Ball3DAgent : Agent | |||
{ | |||
[Header("Specific to Ball3D")] | |||
public GameObject ball; | |||
public bool useVecObs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a Tooltip to explain that this needs to be checked in the 3DBall scene but unchecked in the Visual3DBall scene (since it is a public inspector).
Proposed change(s)
Add a visual version of 3DBall. The agent takes 84x84 camera frame with frame stacking of 4 as input.
A
Use Vec Obs
option is added to 3DBall agent.This can be served as a good example to demonstrate the use of visual frame-stacking for the newly added stacking feature for visual/compressed observation
This PR will wait until #4476 is merged.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments