update barracuda version, enable tests for 2020.2 #4571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Oct 19, 2020
| @@ -150,10 +150,11 @@ def checkout_csharp_version(csharp_version): | |||
| return | |||
|
|
|||
| csharp_tag = f"com.unity.ml-agents_{csharp_version}" | |||
| csharp_dirs = ["com.unity.ml-agents", "Project"] | |||
| csharp_dirs = ["com.unity.ml-agents", "com.unity.ml-agents.extensions", "Project"] | |||
There was a problem hiding this comment.
If we don't sync the extensions package, we'll get compile failures because the current extensions code is not compatible with old package code.
chriselion
commented
Oct 19, 2020
| for csharp_dir in csharp_dirs: | ||
| subprocess.check_call(f"rm -rf {csharp_dir}", shell=True) | ||
| subprocess.check_call(f"git checkout {csharp_tag} -- {csharp_dir}", shell=True) | ||
| # Allow the checkout to fail, since the extensions folder isn't availabe in 1.0.0 | ||
| subprocess.call(f"git checkout {csharp_tag} -- {csharp_dir}", shell=True) |
There was a problem hiding this comment.
... but trying to checkout the directory at old tags before it existed will fail
vincentpierre
approved these changes
Oct 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Upgrade barracuda dependency to 1.1.2-preview. This contains a fix for 2020.2, so we can re-enable that in the test versions.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1464
Types of change(s)
Checklist
Other comments