Skip to content

Cherrypick bug fixes to release_9_branch #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 2, 2020

Conversation

dongruoping
Copy link
Contributor

@dongruoping dongruoping commented Oct 31, 2020

Proposed change(s)

Cherrypick #4593 and cattrs version fix in #4613 .

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Ervin T and others added 3 commits October 30, 2020 17:18
* Always initialize non-wrapped policy

* Load ghosted policy

* Update changelog

* Resume test

* Add test

* Add torch test and fix torch.
@dongruoping dongruoping changed the title Cherrypick TF resume fixes to release_9_branch Cherrypick bug fixes to release_9_branch Oct 31, 2020
@@ -41,6 +41,7 @@ and this project adheres to
- Fixed a bug where accessing the Academy outside of play mode would cause the
Academy to get stepped multiple times when in play mode. (#4532)
#### ml-agents / ml-agents-envs / gym-unity (Python)
- Fixed an issue where runs could not be resumed when using TensorFlow and Ghost Training. (#4593)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should start a new section. You might need to change the C# package to 1.5.1 to get package validation to stop complaining.

@dongruoping dongruoping merged commit 79faafd into release_9_branch Nov 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the release_9_branch_resume_fix branch November 2, 2020 22:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants