chore/Document breaking changes in js client #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalker4
force-pushed
the
chore/sdk-updates
branch
from
f2ec350 to
1d3a576
Compare
awalker4
force-pushed
the
chore/sdk-updates
branch
from
1d3a576 to
4a0f4c8
Compare
awalker4
changed the title
Coniferish
reviewed
Jun 14, 2024
Coniferish
reviewed
Jun 14, 2024
Coniferish
reviewed
Jun 14, 2024
Co-authored-by: John <[email protected]>
Coniferish
reviewed
Jun 14, 2024
| @@ -73,35 +83,46 @@ deployment of Unstructured API, you can access the API using the Python or JavaS | |||
| # Handle the response | |||
| pass | |||
There was a problem hiding this comment.
unrelated to this PR, but I'm noticing now that the response is handled differently in the two python examples. This first example should probably do the same as the Python (SDK <=v0.22.0) tab
Suggested change
| pass | |
| try: | |
| res = client.general.partition(request=req) | |
| print(res.elements[0]) | |
| except SDKError as e: | |
| print(e) |
Coniferish
reviewed
Jun 14, 2024
Coniferish
approved these changes
Jun 14, 2024
* Use data as variable in all samples * Keep the example params consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: