Skip to content

feat: add display name to connectors #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jun 12, 2025
Merged

feat: add display name to connectors #532

merged 28 commits into from
Jun 12, 2025

Conversation

pawel-kmiecik
Copy link
Contributor

@pawel-kmiecik pawel-kmiecik commented Jun 6, 2025 •
edited
Loading

Add display_name attribute for FileData in connectors that miss it

Display name might be helpful when debugging failed processing.
This PR:

  • adds this attribute to the connectors that miss it
  • updates tests to check for that field
  • udpates fixtures/expected processed data files (=fixtures update) - MOST OF THE CHANGES IN THIS PR

@pawel-kmiecik pawel-kmiecik marked this pull request as draft June 6, 2025 08:21
mateuszkuprowski
mateuszkuprowski approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@mateuszkuprowski mateuszkuprowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly the changes are rather simple, and the tests work correctly with new fixtures. Must have taken a long time to check all these, but all this looks good to me.

@pawel-kmiecik pawel-kmiecik merged commit 5abf754 into main Jun 12, 2025
35 of 36 checks passed
@pawel-kmiecik pawel-kmiecik deleted the pawel/add-display-name-to-connectors branch June 12, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszkuprowski mateuszkuprowski mateuszkuprowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawel-kmiecik @mateuszkuprowski