fix: search only for valid attachment links in Confluence page #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds-filipknefel
commented
Jun 10, 2025
| def _find_hyperlink_tags(self, html_soup: "BeautifulSoup") -> list["Tag"]: | ||
| """Find hyperlink tags in the HTML. | ||
|
|
||
| Overwrite this method to customize the tag search. |
There was a problem hiding this comment.
Alternatively I'm thinking this method could be extended instead of overwritten, such that in subclass you'd do the following - however this means you can't use a customized query which you might want to.
tags = super()._find_hyperlink_tags(html_soup)
return [tag for tag in tags if subclass_predicate(tag)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
HtmlMixinto allow for customized hyperlink tag search in subclasses using the mixin by overwriting a dedicated method.Overwrite said method in the
ConfluenceDownloaderConfigto target only embedded attachment files when running withextract_filesflag.