fix: Improve retry mechanisms for split pdf logic #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-homan
force-pushed
the
js-client-retries
branch
from
279fc39 to
cc0e396
Compare
dennison33
reviewed
Sep 10, 2024
There was a problem hiding this comment.
on line 213 wont this assignment fail:
(this.partitionSuccessfulResponses[operationID] as Response[])[pageIndex][pageIndex] =
response.clone();
because this.partitionSuccessfulResponses[operationID] has not been initialized to an array?
Have a look at line 192, the success responses is initialized, but the fail responses is not:
this.partitionSuccessfulResponses[operationID] = new Array(requests.length);
jordan-homan
force-pushed
the
js-client-retries
branch
2 times, most recently
from
04c2406 to
6291cf6
Compare
awalker4
approved these changes
Sep 12, 2024
|
Ah, one sec, we may need to hardcode our retry values in here - let me look. EDIT - all good now. |
jordan-homan
commented
Sep 13, 2024
| const { baseURL } = opts; | ||
| this.client = new HTTPClientExtension(); | ||
|
|
||
| this.client.addHook("response", (res) => { |
There was a problem hiding this comment.
maybe we could move this into the HTTPClientExtension class? not necessary though
jordan-homan
force-pushed
the
js-client-retries
branch
2 times, most recently
from
30260d9 to
16d75a1
Compare
HTTPClient hooks. The autogenerated code takes these values from the `x-speakeasy-retries` section of our OpenAPI spec. However, when we call `retry` directly like this, we need to be able to pass the values in. Once we have a reference to the SDK in the hook context, we can make requests via `s.general.partition` and avoid duplicating logic.
jordan-homan
force-pushed
the
js-client-retries
branch
from
30de60c to
9ca0ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.