fixed Queue.Poll() timout bug, Put() would get stuck on leftover sema #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,6 +85,9 @@ func TestGet(t *testing.T) { | |||
| func TestPoll(t *testing.T) { | |||
| q := New(10) | |||
|
|
|||
| // should be able to Poll() before anything is present, without breaking future Puts | |||
| q.Poll(1, time.Millisecond) | |||
|
|
|||
There was a problem hiding this comment.
without the Poll() code change in place, the next Put() would hang indefinitely
|
+1 |
dustinhiatt-wf
added a commit
that referenced
this pull request
Sep 29, 2015
fixed Queue.Poll() timout bug, Put() would get stuck on leftover sema
|
Thanks! |
|
@Rosie run_merge_script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call Poll() and it times out and returns, then a future call to Put() would hang forever, due to a sema that was left behind.