Rename ParseDictExpr to ParseDictAttrExpr, and cleanup a test.

Author: ttjost

mlir/lib/Tools/PDLL/Parser/Parser.cpp

@@ -318,7 +318,7 @@ class Parser {
   FailureOr<ast::Expr *> parseAttributeExpr();
   FailureOr<ast::Expr *> parseCallExpr(ast::Expr *parentExpr);
   FailureOr<ast::Expr *> parseDeclRefExpr(StringRef name, SMRange loc);
-  FailureOr<ast::Expr *> parseDictExpr();
+  FailureOr<ast::Expr *> parseDictAttrExpr();
   FailureOr<ast::Expr *> parseIdentifierExpr();
   FailureOr<ast::Expr *> parseInlineConstraintLambdaExpr();
   FailureOr<ast::Expr *> parseInlineRewriteLambdaExpr();
@@ -1824,7 +1824,7 @@ FailureOr<ast::Expr *> Parser::parseExpr() {
     lhsExpr = parseTupleExpr();
     break;
   case Token::l_brace:
-    lhsExpr = parseDictExpr();
+    lhsExpr = parseDictAttrExpr();
     break;
   case Token::l_square:
     lhsExpr = parseArrayAttrExpr();
@@ -1947,7 +1947,7 @@ FailureOr<ast::Expr *> Parser::parseDeclRefExpr(StringRef name, SMRange loc) {
   return createDeclRefExpr(loc, decl);
 }
 
-FailureOr<ast::Expr *> Parser::parseDictExpr() {
+FailureOr<ast::Expr *> Parser::parseDictAttrExpr() {
   consumeToken(Token::l_brace);
   SMRange loc = curToken.getLoc();
 

mlir/test/mlir-pdll/CodeGen/MLIR/expr.pdll

@@ -178,8 +178,6 @@ Pattern RewriteOneEntryDictionary {
 // Rewriter helpers declarations.
 Rewrite createDictionaryAttr() -> Attr;
 Rewrite addEntryToDictionaryAttr(dict: Attr, attrName: Attr, attr : Attr) -> Attr;
-Rewrite createArrayAttr() -> Attr;
-Rewrite addElemToArrayAttr(arrayAttr: Attr, newElement: Attr) -> Attr;
 
 // CHECK-LABEL:   pdl.pattern @RewriteMultipleEntriesDictionary
 // CHECK:           %[[VAL_1:.*]] = operation "test.op"