Skip to content

[MLIR] MemRefToEmitC: Lower memref.alloca to emitc.variable #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mgehre-amd
Copy link
Collaborator

No description provided.

Created using spr 1.3.6-beta.1
@mgehre-amd mgehre-amd requested a review from TinaAMD February 28, 2024 15:06
mgehre-amd and others added 2 commits February 28, 2024 18:07
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@mgehre-amd mgehre-amd changed the base branch from users/mgehre/spr/feature/fused-ops.mlir-memreftoemitc-lower-memrefalloca-to-emitcvariable to feature/fused-ops February 28, 2024 17:08
@mgehre-amd mgehre-amd merged commit 0c0289b into feature/fused-ops Feb 28, 2024
@mgehre-amd mgehre-amd deleted the users/mgehre/spr/mlir-memreftoemitc-lower-memrefalloca-to-emitcvariable branch February 28, 2024 17:22
jorickert pushed a commit that referenced this pull request Apr 14, 2025
…464)" (llvm#120511)

This reverts commit 2691b96. This
reapply fixes the buildbot breakage of the original patch, by updating
clang/test/CodeGen/ubsan-trap-debugloc.c to specify -fsanitize-merge
(the default, which is merge, is applied by the driver but not
clang_cc1).

This reapply also expands clang/test/CodeGen/ubsan-trap-merge.c.

----

Original commit message:
'-mllvm -ubsan-unique-traps'
(llvm#65972) applies to all UBSan
checks. This patch introduces -fsanitize-merge (defaults to on,
maintaining the status quo behavior) and -fno-sanitize-merge (equivalent
to '-mllvm -ubsan-unique-traps'), with the option to selectively
applying non-merged handlers to a subset of UBSan checks (e.g.,
-fno-sanitize-merge=bool,enum).

N.B. we do not use "trap" in the argument name since
llvm#119302 has generalized
-ubsan-unique-traps to work for non-trap modes (min-rt and regular rt).

This patch does not remove the -ubsan-unique-traps flag; that will
override -f(no-)sanitize-merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants