Skip to content

Backport: [mlir][emitc] Add ArrayType (#83386) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mgehre-amd
Copy link
Collaborator

This backports the PR that just landed upstream with all its review comments.

This models a one or multi-dimensional C/C++ array.

The type implements the `ShapedTypeInterface` and prints similar to
memref/tensor:
```
  %arg0: !emitc.array<1xf32>,
  %arg1: !emitc.array<10x20x30xi32>,
  %arg2: !emitc.array<30x!emitc.ptr<i32>>,
  %arg3: !emitc.array<30x!emitc.opaque<"int">>
```

It can be translated to a C array type when used as function parameter
or as `emitc.variable` type.
@mgehre-amd mgehre-amd requested a review from TinaAMD March 11, 2024 15:45
Base automatically changed from matthias.backport_emitc to feature/fused-ops March 12, 2024 08:28
@mgehre-amd mgehre-amd requested a review from TinaAMD March 12, 2024 08:31
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd merged commit aec5ee9 into feature/fused-ops Mar 12, 2024
@mgehre-amd mgehre-amd deleted the matthias.backport_array_type branch March 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants