Skip to content

PDLL: Allow to implictly convert Tuple<Attr> with a single element to Attr #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mgehre-amd
Copy link
Collaborator

@mgehre-amd mgehre-amd commented Jan 26, 2024

Parenthesis in PDLL are parsed as tuples. This conversion allows to use parenthesis in math expressions, so that (a +b) can be used as expression, allowing to write (a + b) * c.
Support for the actual math operators will come in a follow-up PR.

@mgehre-amd mgehre-amd requested a review from ttjost January 26, 2024 19:54
… Attr

Parenthesis in PDLL are parsed as tuples. This conversion allows to use parenthesis
in math expressions.
@mgehre-amd mgehre-amd force-pushed the matthias.parentheses branch from 3cd387d to 846d97b Compare January 26, 2024 20:00
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd merged commit fa6f736 into feature/fused-ops Feb 21, 2024
@mgehre-amd mgehre-amd deleted the matthias.parentheses branch February 21, 2024 14:39
mgehre-amd pushed a commit that referenced this pull request Mar 11, 2024
This PR adds support for thread names in lldb on Windows.

```
(lldb) thr list
Process 2960 stopped
  thread #53: tid = 0x03a0, 0x00007ff84582db34 ntdll.dll`NtWaitForMultipleObjects + 20
  thread #29: tid = 0x04ec, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'SPUW.6'
  thread #89: tid = 0x057c, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1000019] physics[main]'
  thread #3: tid = 0x0648, 0x00007ff843c2cafe combase.dll`InternalDoATClassCreate + 39518
  thread #93: tid = 0x0688, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x100501d] uMovie::StreamingThread'
  thread #1: tid = 0x087c, 0x00007ff842e7a104 win32u.dll`NtUserMsgWaitForMultipleObjectsEx + 20
  thread #96: tid = 0x0890, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1002020] HLE Video Decoder'
<...>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants