Exclude namespace from folder apply #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solsson
force-pushed
the
exclude-namespace-from-folder-apply
branch
from
ac0e528 to
b3f56c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and more importantly from kubectl folder delete.
I'm frequently doing experimental setups, where I might for example want to delete and re-create Kafka but not Zookeeper. However because the namespace is included in
kubect delete -f kafka/everything gets removed.I'm intentionally not documenting creation of namespace in README. You'll need proficience with namespaces to use this repo anyway, and kubectl's error messages are very clear when a namespace is missing. The message alerts new users to the bias for a specific namespace in this repo.
Actually there's really no need for a manifest when
kubectl create namespaceis so simple but I'd like to keep the yaml around.This reverts #151.