Skip to content

Upgrade to Kafka 0.11 and test for open issues #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 107 commits into from
Jul 29, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
642c620
Uses latest jre image
solsson Mar 1, 2017
42ea218
Upgrades Kafka to latest release
solsson Mar 1, 2017
3739b24
Upgrades Scala to latest, supported as of Kafka 0.10.2
solsson Mar 1, 2017
a385740
Adds namespace to kubectl commands, matching that in yamls
solsson Mar 1, 2017
1110d59
Makes PV match PVC, avoiding small initial storage becase resize is d…
solsson Mar 1, 2017
b9340fe
0.10.2 adds to the confusion about consumer args, #21
solsson Mar 1, 2017
cfe5cd7
Use a generic kafka image and explicitly override "eligible for delet…
solsson Jun 23, 2017
5bf97fc
Merge branch 'use-generic-kafka-image' into kafka-011
solsson Jun 23, 2017
5b8e94a
Upgrade to development build of the latest 0.11 RC
solsson Jun 23, 2017
5ad1550
Modern kafka clients use a bootstrap servers list to connect...
solsson Jun 23, 2017
6e8cab0
Reuses the statefulset's image in test pods, without tag duplication...
solsson Jun 23, 2017
15bcb87
Borrows string trick from https://github.com/kubernetes/charts/
solsson Jun 24, 2017
401d65e
Merge branch 'no-roundrobin-service' into kafka-011
solsson Jun 25, 2017
a2b658a
Upgrades zookeeper to latest
solsson Jun 23, 2017
344df6e
Uses zookeeper without the bind address sed
solsson Jun 23, 2017
8897c05
We do need the bind address sed. This image logs the at start, to red…
solsson Jun 23, 2017
a9b7a22
Removes out-of-date zookeeper info
solsson Jun 24, 2017
c39b65c
Merge branch 'zookeeper-update' into kafka-011
solsson Jun 25, 2017
07fc0d1
Uses the new small image, with only selected jars from the build
solsson Jun 25, 2017
df88b0d
Default log dir is /tmp/kafka-logs so it should be changed to be insi…
solsson Nov 9, 2016
a83683f
Merge branch 'log-dir-inside-volume' into kafka-011
solsson Jun 25, 2017
5919d45
Support for generic image results in a verbose startup command, make …
solsson Jun 25, 2017
3ab9938
Adds metrics exporter for Prometheus
solsson Jun 25, 2017
a1823a8
Use a specific build, github.com/solsson/dockerfiles/commit/81e8e4c20…
solsson Jun 25, 2017
4a56062
Merge pull request #31 from Yolean/metrics-via-jmx
solsson Jun 25, 2017
4297271
Reindents yaml to match the rest of this repo, and most examples out …
solsson Jun 25, 2017
ccb9e5d
Uses the kafka image as Zookeeper service...
solsson Jun 25, 2017
3344799
Uses the same data path convention as zookeeper, from Confluent Platform
solsson Jun 25, 2017
edf7d84
Merge partial branch 'zookeeper-data', the switch to kafka image
solsson Jun 25, 2017
4351e7c
Uses a named storage class so you can select volume type specifically…
solsson Jun 25, 2017
9479e81
Verified the volume setup with Minikube
solsson Jun 25, 2017
a8c8a39
Updates the readme
solsson Jun 25, 2017
26173af
Enables metrics export to Prometheus, but they look very uninteresting.
solsson Jun 25, 2017
4fd1e5e
Makes persistence a fundamental attribute of the statefulset
solsson Jun 26, 2017
225569f
Creates identical definitions for a non-persistent zoo statefulset
solsson Jun 26, 2017
cb83353
A cluster in three availability zones now get one persistent zk each,…
solsson Jun 26, 2017
4a16d4f
Merge pull request #34 from Yolean/zookeeper-availability-zones
solsson Jun 26, 2017
efb1019
Forks can tweak storage classes, but here we want setup to be simple...
solsson Jun 26, 2017
13e9818
Merge pull request #33 from Yolean/zookeeper-data
solsson Jun 27, 2017
10543bf
Uses dynamically provisioned volume for Kafka too. It has matured, ...
solsson Jun 27, 2017
f45ced5
Adds utility to update the kafka image, which we keep the same to min…
solsson Jun 27, 2017
49865bc
Adds a test that produces a message that you can see in the logs of 2…
solsson Jun 27, 2017
3bc821b
Adds tentative resource requests, based on what idle pods use (though…
solsson Jun 27, 2017
620c4e2
Removes volume claims documentation, as we've gone completely dynamic
solsson Jun 27, 2017
f4ac288
A monitoring-only pod uses 0m / ~32Mi resources
solsson Jun 27, 2017
1a8f2d9
s
solsson Jun 27, 2017
1344238
Got quite repeatable OOMKilled on pzoo pods, so I figured it must be...
solsson Jun 27, 2017
e5ba57e
Merge pull request #35 from Yolean/resource-limits
solsson Jun 27, 2017
411192d
Reverts to default termination period, and uses bash for "shell form"...
solsson Jun 27, 2017
2c4b6cd
Adds probes, but for Kafka I don't think it indicates readiness...
solsson Jun 27, 2017
0ab701c
Reduces termination grace period for zookeeper because I fail to trig…
solsson Jun 27, 2017
b3c6cd2
Raises memory limit for metrics; got 10 OOMKilled per pod in the last…
solsson Jun 27, 2017
53b2cb5
Limiting metrics' JVM to match resource limits. Still getting OOMKill…
solsson Jun 28, 2017
bccfdfa
Upgrades to latest build from https://github.com/solsson/dockerfiles/…
solsson Jun 28, 2017
d6b870c
shell script is now osx, but no longer gnu :)
solsson Jun 28, 2017
4481b4d
Applies the limit to persistent zookeeper pods too. They seem more pr…
solsson Jun 28, 2017
07d895c
Same startup as 51zoo
solsson Jun 28, 2017
ac443a9
Fixes posix compatibility for probes
solsson Jul 23, 2017
9f47cd0
Upgrades to current https://github.com/solsson/dockerfiles/pull/5
solsson Jul 23, 2017
6a934de
solsson/kafka on debian restores installation path to /opt/kafka
solsson Jul 23, 2017
c188f43
Default shell on debian should forward signals properly
solsson Jul 23, 2017
1758478
Adds yaml with the default .properties from 0.11.0.0
solsson Jul 23, 2017
a30b5e7
Use config map's config instead of image's
solsson Jul 25, 2017
b3491ce
Validates against a gotcha
solsson Jul 25, 2017
d8b2b41
With stock config we have to change zookeeper lookup from the default…
solsson Jul 25, 2017
b2ebc80
Merge pull request #43 from Yolean/kafka-011-config-map
solsson Jul 25, 2017
c86ed9c
As recommended by https://www.confluent.io/blog/apache-kafka-for-serv…
solsson Jul 25, 2017
0681cc5
I think time saved by auto-creating topics will be lost ...
solsson Jul 25, 2017
480b5fa
New build with https://github.com/solsson/dockerfiles/pull/9
solsson Jul 25, 2017
8340b11
New build at commit 0314080
solsson Jul 26, 2017
114b773
Clarifies a gotcha: to mount config with log4j.properties ...
solsson Jul 26, 2017
6f8f6d4
Tagged with the policy from https://github.com/solsson/dockerfiles/pu…
solsson Jul 26, 2017
5bb49e3
With explicit log4j path we can change config mount ...
solsson Jul 26, 2017
a2d324d
Default shell on Debian shows the same symptom ...
solsson Jul 26, 2017
be5a820
Demonstrates how an init script can be used to ...
solsson Jul 26, 2017
0d534e8
Moves broker.id config into init script
solsson Jul 26, 2017
bfe7e31
With no bash tricks in command we can use the actual bin ...
solsson Jul 26, 2017
fda7bdb
Employs the init script concept for zookeeper too, reducing duplcation
solsson Jul 26, 2017
082f57a
Places the myid magic number where replicas are
solsson Jul 27, 2017
b848f85
Stops logs from growing when zookeeper is idle
solsson Jul 27, 2017
752cd45
Merge pull request #47 from Yolean/config-init
solsson Jul 27, 2017
fe25fb9
Merge pull request #46 from Yolean/switch-to-debian-image
solsson Jul 27, 2017
829de73
Unimportant
solsson Jul 27, 2017
51c3097
Belongs in the github.com/yolean/kubernetes-monitoring project
solsson Jul 27, 2017
c481cba
This project avoids scripting through addons ...
solsson Jul 28, 2017
22a314a
Makes /metrics export opt-in (through addon branch coming up)
solsson Jul 28, 2017
98635cc
Includes metrics in our prod
solsson Jul 28, 2017
364c9b7
Uses storage classes for our prod
solsson Jul 28, 2017
ba90764
Could be a pitch
solsson Jul 28, 2017
36a3603
Could be the motivation
solsson Jul 28, 2017
dfa82bd
Shorter
solsson Jul 28, 2017
315317f
Shorter still
solsson Jul 28, 2017
7e6df71
If you got this far you don't need Kubernetes intro
solsson Jul 28, 2017
c4f3c41
Reworked in https://github.com/Yolean/kubernetes-kafka/pull/51
solsson Jul 28, 2017
a880307
Metrics intro belongs in ...
solsson Jul 28, 2017
91b4dde
Where to go from here
solsson Jul 28, 2017
21a94a3
Use a lighter readme with more links, as readers' background will var…
solsson Jul 28, 2017
b581659
Review after github render
solsson Jul 28, 2017
8cbd671
Prepares for tests to move to separate namespace
solsson Jul 28, 2017
c7eae1b
Suggests a structure for test cases as single yml
solsson Jul 28, 2017
24c43d2
Working boilerplate, with output to kubectl logs
solsson Jul 28, 2017
c91c42e
Implements the actual test
solsson Jul 28, 2017
754fd2f
Introduces the test automation concept as briefly as possible
solsson Jul 28, 2017
454bea4
Makes room for a more basic basic test
solsson Jul 28, 2017
48bd7c3
Now we're on par with the old tests, but automated
solsson Jul 28, 2017
cabe9be
Merge pull request #51 from Yolean/test-driven-kubernetes-concept
solsson Jul 28, 2017
ab35705
The test concept just caught a mistake
solsson Jul 29, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
246 changes: 246 additions & 0 deletions 10broker-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,246 @@
kind: ConfigMap
metadata:
name: broker-config
namespace: kafka
apiVersion: v1
data:
init.sh: |-
#!/bin/bash
set -x

export KAFKA_BROKER_ID=${HOSTNAME##*-}
sed -i "s/\${KAFKA_BROKER_ID}/$KAFKA_BROKER_ID/" /etc/kafka/server.properties

server.properties: |-
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# see kafka.server.KafkaConfig for additional details and defaults

############################# Server Basics #############################

# The id of the broker. This must be set to a unique integer for each broker.
broker.id=${KAFKA_BROKER_ID}

# Switch to enable topic deletion or not, default value is false
#delete.topic.enable=true

############################# Socket Server Settings #############################

# The address the socket server listens on. It will get the value returned from
# java.net.InetAddress.getCanonicalHostName() if not configured.
# FORMAT:
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
#listeners=PLAINTEXT://:9092

# Hostname and port the broker will advertise to producers and consumers. If not set,
# it uses the value for "listeners" if configured. Otherwise, it will use the value
# returned from java.net.InetAddress.getCanonicalHostName().
#advertised.listeners=PLAINTEXT://your.host.name:9092

# Maps listener names to security protocols, the default is for them to be the same. See the config documentation for more details
#listener.security.protocol.map=PLAINTEXT:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_SSL:SASL_SSL

# The number of threads that the server uses for receiving requests from the network and sending responses to the network
num.network.threads=3

# The number of threads that the server uses for processing requests, which may include disk I/O
num.io.threads=8

# The send buffer (SO_SNDBUF) used by the socket server
socket.send.buffer.bytes=102400

# The receive buffer (SO_RCVBUF) used by the socket server
socket.receive.buffer.bytes=102400

# The maximum size of a request that the socket server will accept (protection against OOM)
socket.request.max.bytes=104857600


############################# Log Basics #############################

# A comma seperated list of directories under which to store log files
log.dirs=/tmp/kafka-logs

# The default number of log partitions per topic. More partitions allow greater
# parallelism for consumption, but this will also result in more files across
# the brokers.
num.partitions=1

# The number of threads per data directory to be used for log recovery at startup and flushing at shutdown.
# This value is recommended to be increased for installations with data dirs located in RAID array.
num.recovery.threads.per.data.dir=1

############################# Internal Topic Settings #############################
# The replication factor for the group metadata internal topics "__consumer_offsets" and "__transaction_state"
# For anything other than development testing, a value greater than 1 is recommended for to ensure availability such as 3.
offsets.topic.replication.factor=1
transaction.state.log.replication.factor=1
transaction.state.log.min.isr=1

############################# Log Flush Policy #############################

# Messages are immediately written to the filesystem but by default we only fsync() to sync
# the OS cache lazily. The following configurations control the flush of data to disk.
# There are a few important trade-offs here:
# 1. Durability: Unflushed data may be lost if you are not using replication.
# 2. Latency: Very large flush intervals may lead to latency spikes when the flush does occur as there will be a lot of data to flush.
# 3. Throughput: The flush is generally the most expensive operation, and a small flush interval may lead to exceessive seeks.
# The settings below allow one to configure the flush policy to flush data after a period of time or
# every N messages (or both). This can be done globally and overridden on a per-topic basis.

# The number of messages to accept before forcing a flush of data to disk
#log.flush.interval.messages=10000

# The maximum amount of time a message can sit in a log before we force a flush
#log.flush.interval.ms=1000

############################# Log Retention Policy #############################

# The following configurations control the disposal of log segments. The policy can
# be set to delete segments after a period of time, or after a given size has accumulated.
# A segment will be deleted whenever *either* of these criteria are met. Deletion always happens
# from the end of the log.

# The minimum age of a log file to be eligible for deletion due to age
log.retention.hours=168

# A size-based retention policy for logs. Segments are pruned from the log as long as the remaining
# segments don't drop below log.retention.bytes. Functions independently of log.retention.hours.
#log.retention.bytes=1073741824

# The maximum size of a log segment file. When this size is reached a new log segment will be created.
log.segment.bytes=1073741824

# The interval at which log segments are checked to see if they can be deleted according
# to the retention policies
log.retention.check.interval.ms=300000

############################# Zookeeper #############################

# Zookeeper connection string (see zookeeper docs for details).
# This is a comma separated host:port pairs, each corresponding to a zk
# server. e.g. "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002".
# You can also append an optional chroot string to the urls to specify the
# root directory for all kafka znodes.
zookeeper.connect=localhost:2181

# Timeout in ms for connecting to zookeeper
zookeeper.connection.timeout.ms=6000


############################# Group Coordinator Settings #############################

# The following configuration specifies the time, in milliseconds, that the GroupCoordinator will delay the initial consumer rebalance.
# The rebalance will be further delayed by the value of group.initial.rebalance.delay.ms as new members join the group, up to a maximum of max.poll.interval.ms.
# The default value for this is 3 seconds.
# We override this to 0 here as it makes for a better out-of-the-box experience for development and testing.
# However, in production environments the default value of 3 seconds is more suitable as this will help to avoid unnecessary, and potentially expensive, rebalances during application startup.
group.initial.rebalance.delay.ms=0

log4j.properties: |-
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Unspecified loggers and loggers with additivity=true output to server.log and stdout
# Note that INFO only applies to unspecified loggers, the log level of the child logger is used otherwise
log4j.rootLogger=INFO, stdout, kafkaAppender

log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
log4j.appender.stdout.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.kafkaAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.kafkaAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.kafkaAppender.File=${kafka.logs.dir}/server.log
log4j.appender.kafkaAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.kafkaAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.stateChangeAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.stateChangeAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.stateChangeAppender.File=${kafka.logs.dir}/state-change.log
log4j.appender.stateChangeAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.stateChangeAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.requestAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.requestAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.requestAppender.File=${kafka.logs.dir}/kafka-request.log
log4j.appender.requestAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.requestAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.cleanerAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.cleanerAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.cleanerAppender.File=${kafka.logs.dir}/log-cleaner.log
log4j.appender.cleanerAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.cleanerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.controllerAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.controllerAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.controllerAppender.File=${kafka.logs.dir}/controller.log
log4j.appender.controllerAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.controllerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

log4j.appender.authorizerAppender=org.apache.log4j.DailyRollingFileAppender
log4j.appender.authorizerAppender.DatePattern='.'yyyy-MM-dd-HH
log4j.appender.authorizerAppender.File=${kafka.logs.dir}/kafka-authorizer.log
log4j.appender.authorizerAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.authorizerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

# Change the two lines below to adjust ZK client logging
log4j.logger.org.I0Itec.zkclient.ZkClient=INFO
log4j.logger.org.apache.zookeeper=INFO

# Change the two lines below to adjust the general broker logging level (output to server.log and stdout)
log4j.logger.kafka=INFO
log4j.logger.org.apache.kafka=INFO

# Change to DEBUG or TRACE to enable request logging
log4j.logger.kafka.request.logger=WARN, requestAppender
log4j.additivity.kafka.request.logger=false

# Uncomment the lines below and change log4j.logger.kafka.network.RequestChannel$ to TRACE for additional output
# related to the handling of requests
#log4j.logger.kafka.network.Processor=TRACE, requestAppender
#log4j.logger.kafka.server.KafkaApis=TRACE, requestAppender
#log4j.additivity.kafka.server.KafkaApis=false
log4j.logger.kafka.network.RequestChannel$=WARN, requestAppender
log4j.additivity.kafka.network.RequestChannel$=false

log4j.logger.kafka.controller=TRACE, controllerAppender
log4j.additivity.kafka.controller=false

log4j.logger.kafka.log.LogCleaner=INFO, cleanerAppender
log4j.additivity.kafka.log.LogCleaner=false

log4j.logger.state.change.logger=TRACE, stateChangeAppender
log4j.additivity.state.change.logger=false

# Change to DEBUG to enable audit log for the authorizer
log4j.logger.kafka.authorizer.logger=WARN, authorizerAppender
log4j.additivity.kafka.authorizer.logger=false
48 changes: 0 additions & 48 deletions 10pvc.yml

This file was deleted.

11 changes: 0 additions & 11 deletions 30service.yml

This file was deleted.

50 changes: 42 additions & 8 deletions 50kafka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,57 @@ spec:
metadata:
labels:
app: kafka
annotations:
spec:
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 30
initContainers:
- name: init-config
image: solsson/kafka:0.11.0.0@sha256:b27560de08d30ebf96d12e74f80afcaca503ad4ca3103e63b1fd43a2e4c976ce
command: ['/bin/bash', '/etc/kafka/init.sh']
volumeMounts:
- name: config
mountPath: /etc/kafka
containers:
- name: broker
image: solsson/kafka-persistent:0.10.1@sha256:0719b4688b666490abf4b32a3cc5c5da7bb2d6276b47377b35de5429f783e9c2
image: solsson/kafka:0.11.0.0@sha256:b27560de08d30ebf96d12e74f80afcaca503ad4ca3103e63b1fd43a2e4c976ce
env:
- name: KAFKA_LOG4J_OPTS
value: -Dlog4j.configuration=file:/etc/kafka/log4j.properties
ports:
- containerPort: 9092
command:
- sh
- -c
- "./bin/kafka-server-start.sh config/server.properties --override broker.id=$(hostname | awk -F'-' '{print $2}')"
- ./bin/kafka-server-start.sh
- /etc/kafka/server.properties
- --override
- zookeeper.connect=zookeeper:2181
- --override
- log.retention.hours=-1
- --override
- log.dirs=/var/lib/kafka/data/topics
- --override
- auto.create.topics.enable=false
resources:
requests:
cpu: 100m
memory: 512Mi
livenessProbe:
exec:
command:
- /bin/sh
- -c
- 'echo "" | nc -w 1 127.0.0.1 9092'
volumeMounts:
- name: datadir
mountPath: /opt/kafka/data
- name: config
mountPath: /etc/kafka
- name: data
mountPath: /var/lib/kafka/data
volumes:
- name: config
configMap:
name: broker-config
volumeClaimTemplates:
- metadata:
name: datadir
name: data
spec:
accessModes: [ "ReadWriteOnce" ]
resources:
Expand Down
Loading