Skip to content

Use k8s 1.8 storage class syntax and set Retain by default #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 50kafka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ spec:
name: data
spec:
accessModes: [ "ReadWriteOnce" ]
storageClassName: kafka-broker
resources:
requests:
storage: 200Gi
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ The goal is to provide [Bootstrap servers](http://kafka.apache.org/documentation

Zookeeper at `zookeeper.kafka.svc.cluster.local:2181`.

## Prepare storage classes

For Minikube run `kubectl apply -f configure/minikube-storageclass-broker.yml; kubectl apply -f configure/minikube-storageclass-zookeeper.yml`.

There's a similar setup for GKE, `configure/gke-*`. You might want to tweak it before creating.

## Start Zookeeper

The [Kafka book](https://www.confluent.io/resources/kafka-definitive-guide-preview-edition/) recommends that Kafka has its own Zookeeper cluster with at least 5 instances.
Expand Down Expand Up @@ -64,14 +70,6 @@ For clusters that enfoce [RBAC](https://kubernetes.io/docs/admin/authorization/r
kubectl apply -f rbac-namespace-default/
```

## Caution: `Delete` Reclaim Policy is default

In production you likely want to [manually set Reclaim Policy](https://kubernetes.io/docs/tasks/administer-cluster/change-pv-reclaim-policy/),
or your data will be gone if the generated [volume claim](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#persistentvolumeclaims)s are deleted.

This can't be done [in manifests](https://github.com/Yolean/kubernetes-kafka/pull/50),
at least not [until Kubernetes 1.8](https://github.com/kubernetes/features/issues/352).

## Tests

Tests are based on the [kube-test](https://github.com/Yolean/kube-test) concept.
Expand Down
8 changes: 8 additions & 0 deletions configure/gke-storageclass-broker-pd.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: kafka-broker
provisioner: kubernetes.io/gce-pd
reclaimPolicy: Retain
parameters:
type: pd-standard
8 changes: 8 additions & 0 deletions configure/gke-storageclass-zookeeper-ssd.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: kafka-zookeeper
provisioner: kubernetes.io/gce-pd
reclaimPolicy: Retain
parameters:
type: pd-ssd
6 changes: 6 additions & 0 deletions configure/minikube-storageclass-broker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: kafka-broker
provisioner: k8s.io/minikube-hostpath
reclaimPolicy: Retain
6 changes: 6 additions & 0 deletions configure/minikube-storageclass-zookeeper.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: kafka-zookeeper
provisioner: k8s.io/minikube-hostpath
reclaimPolicy: Retain
3 changes: 2 additions & 1 deletion zookeeper/50pzoo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
name: data
spec:
accessModes: [ "ReadWriteOnce" ]
storageClassName: kafka-zookeeper
resources:
requests:
storage: 10Gi
storage: 1Gi