fix(cli): allow passing n_ctx=0 to openAI API server CLI arguments #1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the OpenAI API server's command line arguments to allow passing
--n_ctx 0
as a command-line argument. Currently,--n_ctx
parameter has a minimum of1
: inllama_cpp/server/settings.py
you can see the following context CLI parameter configuration:n_ctx: int = Field(default=2048, ge=1, description="The context size.")
Why?
As of
[email protected]
, per #1015 by @DanieleMorotti, passingn_ctx=0
to theLLama
class inllama_cpp/llama.py
automatically sets then_ctx
to the model'sn_ctx_train
paramter from KV, and also updates the model'sn_batch
tomin(n_ctx, n_batch)
. This is intentional to allowllama-cpp-python
to infer the context size from the GGUF model file's KV parameters.However, when this change was made, the OpenAI API server's CLI argument configuration was not updated, so the minimum value for the option remained at
1
- making the patch in #1015 unavailable to users of the OpenAI API serve.r