Skip to content

fix: handling for content-type application/json with a charset parameter #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JochenDiekenbrock
Copy link

Fixes #440

@JochenDiekenbrock
Copy link
Author

I did not really understand the tests structure. If the test I have added should be written differently, please advise.

@js2me
Copy link
Member

js2me commented Nov 3, 2022

@JochenDiekenbrock Hi, thanks for your PR, please change target branch to next

New tests are not needed, just before commit run the command npm run prepare

@JochenDiekenbrock JochenDiekenbrock changed the base branch from master to next November 3, 2022 08:28
@JochenDiekenbrock
Copy link
Author

Sorry, it was a long day. After this is merged, I will have a look at #312 and will open another PR.

@JochenDiekenbrock
Copy link
Author

npm run prepare produced no changes.

@js2me
Copy link
Member

js2me commented Nov 4, 2022

@JochenDiekenbrock thank you for your contributions!

@js2me js2me merged commit e6e2649 into acacode:next Nov 4, 2022
@js2me
Copy link
Member

js2me commented Nov 4, 2022

@all-contributors please add @JochenDiekenbrock for code bugs

@allcontributors
Copy link
Contributor

@js2me

I've put up a pull request to add @JochenDiekenbrock! 🎉

@JochenDiekenbrock JochenDiekenbrock deleted the fix-content-type-with-charset branch November 4, 2022 08:27
@js2me js2me mentioned this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mime types with charset parameter is not handled
2 participants