[AArch64] Make +pauth enabled in Armv8.3-a by default (#78027) #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: This is just a cherry-pick of the
a52eea6 mainline commit.
Due to the structure of the involved files, cherry-picking required
fixing lots of trivial merge conflicts here and there.
If you are rebasing elf-pauth branch on top of the mainline `main`
branch after the original commit, most probably you can just skip
this cherry-picked one.
Add AEK_PAUTH to ARMV8_3A in TargetParser and let it propagate to
ARMV8R, as it aligns with GCC defaults.
After adding AEK_PAUTH, several tests from TargetParserTest.cpp crashed
when trying to format an error message, thus update a format string in
AssertSameExtensionFlags to account for bitmask being pre-formatted as
std::string.
The CHECK-PAUTH* lines in aarch64-target-features.c are updated to
account for the fact that FEAT_PAUTH support and pac-ret can be enabled
independently and all four combinations are possible.
kovdan01
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
I've not dove deeply into ARM documentation since it was already done by reviewers in original mainline PR and I assume that enough (please let me know if you want me to perform the review "from scratch" just like guys in mainline did).
In terms of cherry-picking and fixing merge conflicts and any stuff which differs from the mainline - LGTM.
This is exactly as intended, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This is just a cherry-pick of the
a52eea6 mainline commit.
Due to the structure of the involved files, cherry-picking required
fixing lots of trivial merge conflicts here and there.
If you are rebasing elf-pauth branch on top of the mainline
mainbranch after the original commit, most probably you can just skip
this cherry-picked one.
Add AEK_PAUTH to ARMV8_3A in TargetParser and let it propagate to ARMV8R, as it aligns with GCC defaults.
After adding AEK_PAUTH, several tests from TargetParserTest.cpp crashed when trying to format an error message, thus update a format string in AssertSameExtensionFlags to account for bitmask being pre-formatted as std::string.
The CHECK-PAUTH* lines in aarch64-target-features.c are updated to account for the fact that FEAT_PAUTH support and pac-ret can be enabled independently and all four combinations are possible.