Skip to content

Commit c758edb

Browse files
aciidghddunbar
authored andcommitted
Swift binding fixes (swiftlang#25)
* [swift-bindings] Add to test target dependency only if swiftc is found * [swift-bindings] don't assume build dir in swift-binding test
1 parent 437ce6c commit c758edb

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

tests/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ if(PYTHONINTERP_FOUND)
3333
--param build_mode=${build_mode})
3434

3535
set(test_target_dependencies
36-
llbuild libllbuild swift-bindings swift-build-tool UnitTests)
36+
llbuild libllbuild swift-build-tool UnitTests)
37+
38+
if (SWIFTC_FOUND)
39+
list(APPEND test_target_dependencies swift-bindings)
40+
endif()
3741

3842
add_custom_target(test-llbuild
3943
COMMAND ${lit_command} ${CMAKE_CURRENT_BINARY_DIR}

tests/Examples/swift-bindings/core/basic.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Check basic 'core' functionality of the swift bindings
22
#
33
# REQUIRES: has-swift=TRUE
4-
# RUN: env LD_LIBRARY_PATH=%{llbuild-lib-dir} %{swiftc} %{swiftc-platform-flags} %{srcroot}/examples/swift-bindings/core/basic.swift -I %{srcroot}/build/products/swift-bindings -I %{srcroot}/products/libllbuild/public-api -Xlinker %{llbuild-lib-dir}/swift-bindings.dylib -o %t.exe
4+
# RUN: env LD_LIBRARY_PATH=%{llbuild-lib-dir} %{swiftc} %{swiftc-platform-flags} %{srcroot}/examples/swift-bindings/core/basic.swift -I %{build-dir}/products/swift-bindings -I %{srcroot}/products/libllbuild/public-api -Xlinker %{llbuild-lib-dir}/swift-bindings.dylib -o %t.exe
55
# RUN: env LD_LIBRARY_PATH=%{llbuild-lib-dir} %t.exe %s > %t.out
66
# RUN: cat %t.out
77
# RUN: %{FileCheck} %s --input-file %t.out

tests/lit.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ config.substitutions.append( ('%{swiftc}', config.swiftc_path) )
7979
config.substitutions.append( ('%{llbuild-lib-dir}', llbuild_lib_dir) )
8080
config.substitutions.append( ('%{srcroot}', llbuild_src_root) )
8181
config.substitutions.append( ('%{swiftc-platform-flags}', "" if not config.osx_sysroot else "-sdk " + config.osx_sysroot) )
82+
config.substitutions.append( ('%{build-dir}', llbuild_obj_root) )
8283

8384
###
8485

0 commit comments

Comments
 (0)