Fix "minor" version dependency pinning #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a major and minor version are provided, the version range should be locked to patches of that minor version.
nonsensery
changed the title
mxcl
added a commit
that referenced
this pull request
Dec 4, 2015
Fix "minor" version dependency pinning
|
Wonderful PR, thank you. It is truly a pleasure when so much information is provided. |
aciidgh
added a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
* [swift-bindings] Add to test target dependency only if swiftc is found * [swift-bindings] don't assume build dir in swift-binding test
sergiocampama
pushed a commit
that referenced
this pull request
Apr 20, 2020
Split process output between stdout and stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes the pinning of dependencies with major and minor version numbers specified.
Where should the reviewer start?
The diff is just one line, but the change is significant. If the package manifest specifies both major and minor version numbers for a dependency, it should be pinned to only allow differences in the patch number.
How should this be manually tested?
1.0.0,1.0.1and1.1.0.1.0.xof Package A..Package("https://example.com/pkg-a.git", majorVersion: 1, minor: 0)1.0.1of Package A, not version1.1.0.Any background context you want to provide?
Previously, there was no difference between a dependency specified with only a major version, and one specified with a major and minor version. Seems like probably just a copy-paste error.