Skip to content

Upgrade to ada 2.7.0, bump version to 1.6.0, add URLSearchParams #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

Upgrade to ada 2.7.0, bump version to 1.6.0, add URLSearchParams #39

merged 2 commits into from
Oct 11, 2023

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Oct 10, 2023

This PR:

  • Adds support for the new URLSearchParams functionality
  • Upgrades to ada 2.7.0
  • Bumps the version of the library to 1.6.0

In addition to the standard URLSearchParams class, I've also added two convenience methods for Python users:

  • parse_search_params, akin to urllib.parse.parse_qsl
  • replace_search_params, can substitute for urllib.parse.urlencode on a parsed query string

anonrig
anonrig approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bbayles bbayles merged commit f81e274 into main Oct 11, 2023
@bbayles bbayles deleted the url-parameters branch October 11, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbayles @anonrig