-
Notifications
You must be signed in to change notification settings - Fork 9
add option to specify baudrate #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added argument to `__init__` to allow users to set baudrate if desired retains previous default if unspecified
I don't know enough about how the CI checks work to be able to tell why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition, thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant to respond to your followup about black
. If you run pre-commit
, it should reformat things accordingly so it will pass if you submit the changes it makes. You can find information on using pre-commit
here:
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code
Unfortunately, I'm not able to run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was an extra bit of whitespace causing the issue. Thanks!
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.4.0 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#25 from semininja/main Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 2.1.9 from 2.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#25 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU31D to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_HTU31D#8 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.15 from 1.2.14: > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#12 from tcfranks/main
added argument to
__init__
to allow users to set baudrate if desiredretains previous default if unspecified