Skip to content

lint #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2023
Merged

lint #1

merged 3 commits into from
Feb 27, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 30, 2023

No description provided.

@tannewt tannewt marked this pull request as ready for review January 30, 2023 22:44
@tannewt tannewt requested a review from a team January 30, 2023 22:44
Comment on lines 43 to 44
.. note:: This library is not available on PyPI yet. Install documentation is included
as a standard element. Stay tuned for PyPI availability!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Thonny looks for PyPI, everything is being added there. The release workflow will do it and now there's no setup.py.disabled file to prevent it. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct it looks like it will get pushed to pypi once a release is made if everything works out.

This note is just leftover from the cookiecutter, I recall seeing it before. Maybe there is a case in there where we could tweak the default to not include this message for adafruit libraries.

I tried to push the change here to remove it, but don't have access (or my ide/git integration is messed up).

I found another small change needed for this repo and the other 7 color eink one.

I'll merge this and then remove the note in a followup with that other change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem pushing does seem to be something wonky on my side. I had the same problem pushing to my own fork but think It's straightened out for now.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question/comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants