Skip to content

Adds in code from working repo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2017
Merged

Adds in code from working repo #1

merged 4 commits into from
Nov 9, 2017

Conversation

caternuson
Copy link
Contributor

@caternuson caternuson commented Nov 7, 2017

Development work was done in a separate repo that began life elsewhere. PRing that code into this repo instead of forking from original.

Code is for this driver support:
adafruit/circuitpython#312

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing. I'll add Dan as well since I'm headed out of town.

=============
This driver depends on:

* `Adafruit CircuitPython <https://github.com/adafruit/circuitpython>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a link to Bus Device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

@tannewt tannewt requested a review from dhalbert November 8, 2017 22:17
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@tannewt tannewt merged commit e731810 into adafruit:master Nov 9, 2017
@laloshifrin laloshifrin mentioned this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants