Skip to content

Initial working code! #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

Initial working code! #1

merged 1 commit into from
Feb 11, 2022

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Feb 10, 2022

No description provided.

@kattni kattni requested a review from a team February 10, 2022 22:26
@kattni
Copy link
Contributor Author

kattni commented Feb 10, 2022 •
edited
Loading

Still looking into the CI failure. I think I can autodoc_mock_imports circuitpython_typing and get it to pass, but something else is going on here. It's passing locally. circuitpython_typing is where WriteableBuffer is, the module comes from Adafruit-Blinka, and for some reason remote Sphinx isn't seeing it remotely. Locally, Sphinx passes on the current state of this PR. As well, this is apparently not the first library this has happened on - so it's worth actually finding the issue instead of simply doing a workaround. Working with @FoamyGuy to see if we can get it sorted out.

@tekktrik
Copy link
Member

If that's the case, is there the chance that other Blinka modules won't need to be mocked, like digitalio?

@kattni kattni merged commit 1cb3e85 into adafruit:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattni @tekktrik @ladyada