Update adafruit_as7341.py #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "F8R" needs to be connected to ADC3 not ADC2. Fixing this solves the issue of F8 channel reading being wrong. I have double checked this with the c++ code and with an actual spectrometer.
|
Fixes #6. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#7 from afaghm/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.0.0 from 1.0.1: > Correct LC709023F to LC709203F (adafruit/Adafruit_CircuitPython_LC709203F#8) Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.11.0 from 2.10.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#102 from jepler/use-ascent-descent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a minor mistake in SMUX settings leading to incorrect reading in one channel.
The "F8R" needs to be connected to ADC3 not ADC2. Fixing this solves the issue of F8 channel reading being wrong. I have double checked this with the c++ code and with an actual spectrometer.