Skip to content

Add binascii lib in setup.py and fix setup #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

Add binascii lib in setup.py and fix setup #10

merged 2 commits into from
Mar 3, 2020

Conversation

fgallaire
Copy link
Contributor

@fgallaire fgallaire commented Feb 28, 2020 •
edited
Loading

shinny distutils

@fgallaire fgallaire changed the title Add binascii lib in setup.py Add binascii lib in setup.py and fix setup Feb 28, 2020
@ptorrone
Copy link
Member

hi @fgallaire please edit the comment with the 💩-word and we'll check out the PR, we (and the community) would very much appreciate that. no big deal, just use another word or emoji is OK :)

@ladyada ladyada requested a review from brentru March 2, 2020 03:59
@fgallaire
Copy link
Contributor Author

fgallaire commented Mar 2, 2020 •
edited
Loading

@brentru

  1. the previous change in requirements.txt was doing nothing, it has to be done in setup.py
  2. switch from py_modules to packages for fine installation

@brentru
Copy link
Member

brentru commented Mar 3, 2020

@fgallaire Thanks for taking a look at this - LGTM.

Noting for later that the switch from py_modules to packages is because the Adafruit ATECC library files are a package folder.

@brentru brentru merged commit cdfca6c into adafruit:master Mar 3, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 4, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@9ff0667)
e8e6158 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ATECC to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ATECC#10 from fgallaire/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_binascii to 1.1 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_binascii#7 from fgallaire/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 2.1.4 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#28 from kattni/image-example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru Awaiting requested review from brentru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgallaire @ptorrone @brentru