Skip to content

ESP_AT Support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2019
Merged

ESP_AT Support #15

merged 5 commits into from
Feb 28, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 28, 2019

  • Added reference to library in README
  • Added modified example for using the esp_at libary with CircuitPython_AdafruitIO

@brentru brentru added the enhancement New feature or request label Feb 28, 2019
@brentru brentru requested a review from jerryneedell February 28, 2019 15:07
jerryneedell
jerryneedell reviewed Feb 28, 2019
View reviewed changes
jerryneedell
jerryneedell requested changes Feb 28, 2019
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested minor change -- otherwise I ran this on my Argon and it works fine

jerryneedell
jerryneedell approved these changes Feb 28, 2019
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@brentru brentru merged commit e412b28 into adafruit:master Feb 28, 2019
@brentru brentru deleted the add-espatcontrol-support branch February 28, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @jerryneedell