Change requirements to pypi format, remove ESP32SPI requirement #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Jul 13, 2022
There was a problem hiding this comment.
One of the things that will happen for the move to pyproect.toml is that optional dependencies used in optional functionalities and examples will get moved to a new optional_requirements.txt so that they can be pip installed using:
pip install libname[optional]Since the ESP32SPI library gets used in examples, can you add it to a new file named optional_requirements.txt in preparation for that? Should be harmless in the meantime. But removing it from the other two files is great!
Other than that, I'm not sure either if this will fix the issue you mentioned, but fixing the names to be closer to the PyPI name is a good thing regardless!
tekktrik
approved these changes
Jul 13, 2022
|
Thanks! |
kattni
approved these changes
Jul 13, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 14, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.14 from 2.3.13: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#29 from luizvital/main Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.9 from 5.6.8: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#93 from Neradoc/change-requirements Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MMC56x3, Adafruit_CircuitPython_PCF8574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library does not need ESP32SPI, it works on native wifi too.
The format used for the minimqtt requirement makes it listed in "external_dependencies" instead of "dependencies" in the bundle's json file. It might be what is tripping the project bundler for the learn guides using adafruit_io, or indirectly via portalbase. At least that's my assumption.
adafruit_minimqttis missing from the Project Bundle there for example: