Skip to content

fix eddystone packet header byte order #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2019
Merged

fix eddystone packet header byte order #4

merged 1 commit into from
Jan 13, 2019

Conversation

jerryneedell
Copy link
Contributor

@jerryneedell jerryneedell commented Jan 13, 2019

I notice that is I set the tx power ,my app was not recognizing the URL in the Eddystone beacon.
Lookin at the spec

https://github.com/google/eddystone/tree/master/eddystone-url
I think the tx_power and url scheme fields are reversed
swapping them seems to work, my App now set the URL with a non-zero tx_power.

before , with tx_power = 0 it was still a "valid" url_scheme so it worked until tx_power was set.

reported by receiving app (IOS Locate Beacon)
before change

Tx_power - default = 0
UUID: FEAA Data: 10 03 00 61 64 61 66 72 75 2E 69 74 2F 34 30 36 32 
tx_power = -54
UUID: FEAA Data: 10 03 CA 61 64 61 66 72 75 2E 69 74 2F 34 30 36 32 

after change

UUID: FEAA Data: 10 00 03 61 64 61 66 72 75 2E 69 74 2F 34 30 36 32
tx_power = -54
UUID: FEAA Data: 10 CA 03 61 64 61 66 72 75 2E 69 74 2F 34 30 36 32 

@jerryneedell jerryneedell requested a review from dhalbert January 13, 2019 15:39
@dhalbert
Copy link
Collaborator

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit fa7b8bc into adafruit:master Jan 13, 2019
@jerryneedell jerryneedell deleted the jerryn_eddy branch January 13, 2019 15:48
tannewt pushed a commit to tannewt/Adafruit_CircuitPython_BLE that referenced this pull request Mar 22, 2021
Bring build.yml To New Standard Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants