Skip to content

Add UARTService; add standard library files #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2019
Merged

Add UARTService; add standard library files #5

merged 5 commits into from
Jan 23, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert requested review from tannewt and ladyada January 22, 2019 01:59
tannewt
tannewt reviewed Jan 22, 2019
View reviewed changes
tannewt
tannewt reviewed Jan 22, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One naming question then good.

adafruit_ble/uart.py Outdated
from .uuid import UUID
from .characteristic import Characteristic
from .service import Service
from .peripheral_server import PeripheralServer

class UARTService:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be UARTPeripheral or something else instead of service because it cannot be used with other services?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree UARTService is probably misleading. How about UARTServer? It doesn't really act as either a subclass of Service or a subclass of Peripheral.

Copy link
Collaborator Author

@dhalbert dhalbert Jan 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it really is officially a server, in terms of it being a GATT server.

tannewt
tannewt approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@tannewt tannewt merged commit 2246567 into adafruit:master Jan 23, 2019
@dhalbert dhalbert deleted the bleio2 branch January 23, 2019 02:16
tannewt pushed a commit to tannewt/Adafruit_CircuitPython_BLE that referenced this pull request Mar 22, 2021
@kattni
Merge pull request adafruit#5 from sommersoft/patch_coc
7de1832 
Update Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@ladyada ladyada Awaiting requested review from ladyada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt